Implement IPv6 support for DNS, fix some DNS server behaviours #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows the DNS server to serve IPv6 address records (AAAA) for both interaction and NS glue. In combination with the changes in PRs #181 and #182 this allows for IPv6 interaction and provides more opportunities for interaction to ocurr when e.g. IPv6 and IPv4 egress firewalling differ on a network being tested. Specifying the '-ip' option multiple times now allows setting multiple response addresses for the DNS server. Both IPv4 and IPv6 addresses are supported. If no IP address is specified the auto-detected address will be logged at startup time to aid with troubleshooting. Fixes a couple of behaviour bugs with the DNS server implementation and changes the default TTL to 5 from 3600.
ehsandeep
requested review from
Mzack9999 and
Ice3man543
and removed request for
Mzack9999
|
I should say as well: this is a fairly big diff and I'm certainly open to revising it if it isn't in line with your plans for things. |
ehsandeep
added
the
Status: Review Needed
|
Hi folks, I'm going to look at re-writing this patch and will re-submit it against current dev. Cheers, |
|
@pulse-michaelfincham thank you 🙌🏻 It would be great if you could split the PR into multiple, each with a particular change. |
|
@pulse-michaelfincham I created #307 for one of the features introduced in this, and I intended to do the same for two other changes made in this PR, but I don't have enough context, so I'll leave it up to you to put it in the PR or issue. Thanks again, closing this PR now as this will be handled separately. |
ehsandeep
removed
the
Status: Review Needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows the DNS server to serve IPv6 address records (AAAA) for both interaction and NS glue. In combination with the changes in #181 and #182 this allows for IPv6 interaction and provides more opportunities for interaction to ocurr when e.g. IPv6 and IPv4 egress firewalling differ on a network being tested.
Specifying the '-ip' option multiple times now allows setting multiple response addresses for the DNS server. Both IPv4 and IPv6 addresses are supported. If no IP address is specified the auto-detected address will be logged at startup time to aid with troubleshooting.
Fixes a couple of behaviour bugs with the DNS server implementation and changes the default TTL to
5from3600.