Dynamic HDMI device selection #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkdeepa
force-pushed
the
audio_hdmi_dynamic
branch
2 times, most recently
from
2b0e5b4 to
772ee74
Compare
akodanka
reviewed
Aug 18, 2021
| } | ||
| } | ||
| ALOGV("%s exit",__func__); | ||
| return DEFAULT_DEVICE; |
There was a problem hiding this comment.
Would it be better to return -1 from here, and hardcode the default from the caller ?
hdmi/tinyaudio_hw.c
Outdated
| ALOGV("ctl_name %s",ctl_name); | ||
| ctl = mixer_get_ctl_by_name(mixer, ctl_name); | ||
| if(ctl) { | ||
| mixer_type = mixer_ctl_get_type(ctl); |
There was a problem hiding this comment.
Since these variables are unused, should we remove these ?
hdmi/tinyaudio_hw.c
Outdated
| return -1; | ||
| } | ||
| for(i=0; i < MAX_HDMI_DEVICES; i++ ) { | ||
| char ctl_name[100] = "HDMI/DP,pcm="; |
There was a problem hiding this comment.
Can we do this instead :
sprintf(ctl_name, "HDMI/DP,pcm=%d Jack", i);
39df263 to
87ca340
Compare
gkdeepa
force-pushed
the
audio_hdmi_dynamic
branch
7 times, most recently
from
34c29b8 to
680dbf9
Compare
gkdeepa
force-pushed
the
audio_hdmi_dynamic
branch
2 times, most recently
from
3866bf7 to
fc55db6
Compare
Check for the HDMI device status and assign the device id Tracked-On: OAM-98156
gkdeepa
force-pushed
the
audio_hdmi_dynamic
branch
from
fc55db6 to
91206b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for the HDMI device status
and assign the device id
Tracked-On: