Fix playback 4k and 1080p video stuck issue #211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sysopenci
added
Valid commit message
Pending Developer Approval
sysopenci
requested review from
dyang23,
feijiang1,
gkdeepa,
TianmiChen,
yaoxinshi-intel,
YuanjunHuang and
yyao3
Issue is when playing 4k or 1080p video with gallery, video get stuck on android 15. Cause is when c2 service change from hidl to aidl, block pool used in framework will change from buffer queue to IGBA, when allocating surface, surface metadata of igbp_id and igbp_slot will not be updated because they are buffer queue related concept. While in mediasdk_c2, it was checking igbp_id and igbp_slot during InitDecoder(), and caused IO pattern changed from video memory to system memory. Solution is removing checking of igbp_id and igbp_slot for now. This way will cause some vts test fail, which will need be fixed. Tracked-On: OAM-128397 Tracked-On: OAM-128324 Tracked-On: OAM-128315 Signed-off-by: Lina Sun <[email protected]>
lsun30
force-pushed
the
video_play_stuck
branch
from
3727866 to
5a44323
Compare
|
moved to #206 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue is when playing 4k or 1080p video with gallery, video get stuck on android 15.
Cause is when c2 service change from hidl to aidl, block pool used in framework will change from buffer queue to IGBA, when allocating surface, surface metadata of igbp_id and igbp_slot will not be updated because they are buffer queue related concept. While in mediasdk_c2, it was checking igbp_id and igbp_slot during InitDecoder(), and caused IO pattern changed from video memory to system memory.
Solution is removing checking of igbp_id and igbp_slot for now. This way will cause some vts test fail, which will need be fixed.
Tracked-On: OAM-128397
Tracked-On: OAM-128324
Tracked-On: OAM-128315