Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: deprecate single manifest installer #1119

Merged
merged 2 commits into from
Jul 15, 2024
Merged

docs: deprecate single manifest installer #1119

merged 2 commits into from
Jul 15, 2024

Conversation

maxgio92
Copy link
Collaborator

@maxgio92 maxgio92 commented Jul 1, 2024

Fixes #1063

@netlify Netlify
Copy link

netlify bot commented Jul 1, 2024 •
edited
Loading

✅ Deploy Preview for capsule-documentation canceled.

Name Link
🔨 Latest commit 351a23d
🔍 Latest deploy log https://app.netlify.com/sites/capsule-documentation/deploys/6690dbc66b17ea0008579d82

@maxgio92
docs: cleanup single manifest installation
0ab9ee1 
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
@maxgio92 maxgio92 marked this pull request as ready for review July 2, 2024 19:15
@maxgio92
Copy link
Collaborator Author

maxgio92 commented Jul 2, 2024

Besides, the single manifest creates a CapsuleConfiguration named capsule-default which is not expected by Capsule Proxy, leading to the proxy failure.

@oliverbaehler
Copy link
Collaborator

@maxgio92 could you fix the semantics of the commit and pr title

@prometherion
Copy link
Member

@maxgio92 please, may I ask you to address Oliver's requests?

@maxgio92 maxgio92 changed the title clean: deprecate single manifest installer docs: deprecate single manifest installer Jul 11, 2024
@maxgio92
Copy link
Collaborator Author

Sorry @oliverbaehler @prometherion will do it ASAP

@maxgio92
Copy link
Collaborator Author

Hi @oliverbaehler, ready for review

@maxgio92 maxgio92 merged commit c657b55 into projectcapsule:main Jul 15, 2024
17 checks passed
@maxgio92 maxgio92 deleted the issue/1063 branch July 15, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prometherion prometherion prometherion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(distribution): deprecate installer
3 participants
@maxgio92 @oliverbaehler @prometherion