chore: update to ember v4 #625

velrest · 2023-01-25T16:39:23Z

BREAKING CHANGE:

Ember.js v3.28 or above
Ember CLI v3.28 or above
Node.js v14 or above

velrest · 2023-01-25T16:42:10Z

Currently putting this on-hold since all template files throw the following error:

Build Error (broccoli-persistent-filter:Babel > [Babel: ember-emeis]) in ember-emeis/components/acl-wizzard/select-card.js

/home/jonas/projects/ember-emeis/ember-emeis/components/acl-wizzard/select-card.js: Class constructor SetTransform cannot be invoked without 'new'TypeError: /home/jonas/projects/ember-emeis/ember-emeis/components/acl-wizzard/select-card.js: Class constructor SetTransform cannot be invoked without 'new'
    at preprocess (/home/jonas/projects/ember-emeis/node_modules/ember-source/dist/ember-template-compiler.js:12848:28)
    at normalize (/home/jonas/projects/ember-emeis/node_modules/ember-source/dist/ember-template-compiler.js:13493:15)
    at precompileJSON (/home/jonas/projects/ember-emeis/node_modules/ember-source/dist/ember-template-compiler.js:6120:47)
    at precompile (/home/jonas/projects/ember-emeis/node_modules/ember-source/dist/ember-template-compiler.js:6157:31)
    at precompile (/home/jonas/projects/ember-emeis/node_modules/ember-source/dist/ember-template-compiler.js:19423:37)
    at precompile (/home/jonas/projects/ember-emeis/node_modules/ember-cli-htmlbars/lib/utils.js:222:12)
    at insertCompiledTemplate (/home/jonas/projects/ember-emeis/node_modules/babel-plugin-ember-template-compilation/src/plugin.js:50:42)
    at PluginPass.CallExpression (/home/jonas/projects/ember-emeis/node_modules/babel-plugin-ember-template-compilation/src/plugin.js:142:21)
    at newFn (/home/jonas/projects/ember-emeis/node_modules/@babel/traverse/lib/visitors.js:159:21)
    at NodePath._call (/home/jonas/projects/ember-emeis/node_modules/@babel/traverse/lib/path/context.js:46:20)


Stack Trace and Error Report: /tmp/error.dump.55f1244da272e467d1af8ba6f0af82bb.log

I already tried:

Updating all the dependencies
Debugging ember-template-compiler with no success
npx yarn-deduplicate --packages ember-cli-htmlbars as mentioned in Breaks In Ember v4 DockYard/ember-maybe-in-element#47
package.json resolution for ember-cli-handlebars to ^6.1.1

Help would be appreciated!

Related issues:

velrest · 2023-01-26T16:19:48Z

Currently putting this on-hold since all template files throw the following error:

Build Error (broccoli-persistent-filter:Babel > [Babel: ember-emeis]) in ember-emeis/components/acl-wizzard/select-card.js

/home/jonas/projects/ember-emeis/ember-emeis/components/acl-wizzard/select-card.js: Class constructor SetTransform cannot be invoked without 'new'TypeError: /home/jonas/projects/ember-emeis/ember-emeis/components/acl-wizzard/select-card.js: Class constructor SetTransform cannot be invoked without 'new'
    at preprocess (/home/jonas/projects/ember-emeis/node_modules/ember-source/dist/ember-template-compiler.js:12848:28)
    at normalize (/home/jonas/projects/ember-emeis/node_modules/ember-source/dist/ember-template-compiler.js:13493:15)
    at precompileJSON (/home/jonas/projects/ember-emeis/node_modules/ember-source/dist/ember-template-compiler.js:6120:47)
    at precompile (/home/jonas/projects/ember-emeis/node_modules/ember-source/dist/ember-template-compiler.js:6157:31)
    at precompile (/home/jonas/projects/ember-emeis/node_modules/ember-source/dist/ember-template-compiler.js:19423:37)
    at precompile (/home/jonas/projects/ember-emeis/node_modules/ember-cli-htmlbars/lib/utils.js:222:12)
    at insertCompiledTemplate (/home/jonas/projects/ember-emeis/node_modules/babel-plugin-ember-template-compilation/src/plugin.js:50:42)
    at PluginPass.CallExpression (/home/jonas/projects/ember-emeis/node_modules/babel-plugin-ember-template-compilation/src/plugin.js:142:21)
    at newFn (/home/jonas/projects/ember-emeis/node_modules/@babel/traverse/lib/visitors.js:159:21)
    at NodePath._call (/home/jonas/projects/ember-emeis/node_modules/@babel/traverse/lib/path/context.js:46:20)


Stack Trace and Error Report: /tmp/error.dump.55f1244da272e467d1af8ba6f0af82bb.log

I already tried:

Updating all the dependencies
Debugging ember-template-compiler with no success
npx yarn-deduplicate --packages ember-cli-htmlbars as mentioned in Breaks In Ember v4 DockYard/ember-maybe-in-element#47
package.json resolution for ember-cli-handlebars to ^6.1.1

Help would be appreciated!

Related issues:

I resolved this issue.
Due to SetTransform being so generic i had a hard time to understand, which addon this came from and i thought this was a generic ember build class. Turns out after a rg SetTransform that ember-simple-set-helper still used the old style class version of registerPlugin. Since this addon is deprecated anyway i replaced it with ember-set-helper.

velrest · 2023-01-26T17:38:33Z

I also had issues with upgrading ember-engines to 0.9.0. Other than the official deprecations the package @ember/legacy-built-in-components is now also needed. This is undocumented and there is currently an issue here

velrest · 2023-01-27T09:44:12Z

Putting this on hold for now. There are still a lot of issues with the tests.

derrabauke · 2023-05-01T14:48:00Z

Putting this on hold for now. There are still a lot of issues with the tests.

Can we push this together some time this week?

BREAKING CHANGE: - Ember.js v3.28 or above - Ember CLI v3.28 or above - Node.js v16 or above

BREAKING CHANGE: - Rename `router` service dependency to `hostRouter` due to deprecation Deprecation id: ember-engines.deprecation-router-service-from-host

derrabauke · 2023-06-30T09:13:00Z

This needs ensure-safe-component wrapper or a direct component import (more future safe)

ember-emeis/addon/components/relationship-select.hbs

Line 8 in 7ac04b3

(component (if @multiple "power-select-multiple" "power-select"))

velrest · 2023-06-30T10:56:47Z

[email protected] not working because of issue with embroider.
Results in Uncaught Error: Could not find module `@ember-data/store` imported from `(require)` .

derrabauke · 2023-06-30T13:21:53Z

[email protected] not working because of issue with embroider. Results in Uncaught Error: Could not find module `@ember-data/store` imported from `(require)`.

Honestly, I've no idea what's going wrong here. Tried a couple of things but nothing seems to work.

I think we have two options here:

disable the release test scenario for now
downgrade ember-data

Don't know if @anehx knows what could help us here. 🤷

derrabauke · 2023-06-30T13:25:12Z

Btw: I think the addon/routes/index.js file needs some refactoring as of ember v5:

import Route from "@ember/routing/route";
import { inject as service } from "@ember/service";

export default class IndexRoute extends Route {
  @service hostRouter;

  beforeModel() {
    this.hostRouter.transitionTo("users");
  }
}

velrest · 2023-07-04T11:36:19Z

Btw: I think the addon/routes/index.js file needs some refactoring as of ember v5:

import Route from "@ember/routing/route";
import { inject as service } from "@ember/service";

export default class IndexRoute extends Route {
  @service hostRouter;

  beforeModel() {
    this.hostRouter.transitionTo("users");
  }
}
`

What do you mean? We are using the hostRouter transitionTo here.

derrabauke · 2023-07-04T11:40:19Z

Btw: I think the addon/routes/index.js file needs some refactoring as of ember v5:
import Route from "@ember/routing/route";
import { inject as service } from "@ember/service";

export default class IndexRoute extends Route {
  @service hostRouter;

  beforeModel() {
    this.hostRouter.transitionTo("users");
  }
}
`
What do you mean? We are using the hostRouter transitionTo here.

Sorry for confusing you. The code I've pasted was already refactored. The original is not touched yet and should become the quoted code. :)

BREAKING CHANGE: - Ember.js v3.28 or above - Ember CLI v3.28 or above - Node.js v14 or above

velrest · 2023-07-04T13:00:50Z

Disabled release for now since Started 38m 17s ago due to tests timing out.

derrabauke

nice job! ✨

derrabauke · 2023-07-05T08:47:26Z

🎉 This PR is included in version 8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

velrest self-assigned this Jan 25, 2023

velrest force-pushed the ember_v4 branch from b42afe1 to 8e7bb1d Compare January 25, 2023 16:40

velrest marked this pull request as ready for review January 25, 2023 16:42

velrest force-pushed the ember_v4 branch from 7cac80f to 1048584 Compare January 26, 2023 17:23

velrest requested review from anehx, derrabauke and czosel January 26, 2023 17:40

velrest force-pushed the ember_v4 branch 3 times, most recently from 08bf2bf to a26ca00 Compare January 27, 2023 09:43

derrabauke mentioned this pull request May 1, 2023

chore(deps): upgrade ember-uikit to v8 #658

Merged

velrest added 2 commits June 23, 2023 10:05

chore: update to ember v4

2b2635b

BREAKING CHANGE: - Ember.js v3.28 or above - Ember CLI v3.28 or above - Node.js v16 or above

refactor: rename router service dependency to hostRouter

189723a

BREAKING CHANGE: - Rename `router` service dependency to `hostRouter` due to deprecation Deprecation id: ember-engines.deprecation-router-service-from-host

velrest force-pushed the ember_v4 branch 6 times, most recently from 7d426f1 to 1b5518a Compare June 30, 2023 07:44

velrest force-pushed the ember_v4 branch from 851a134 to 04ced13 Compare June 30, 2023 09:21

velrest force-pushed the ember_v4 branch from 04ced13 to 8d73145 Compare June 30, 2023 11:00

velrest force-pushed the ember_v4 branch from 8d73145 to c1b155d Compare July 4, 2023 11:35

velrest force-pushed the ember_v4 branch 3 times, most recently from 1192093 to ab5ab44 Compare July 4, 2023 12:17

chore: udpate to ember 4.12 and make embroider optimized

12d2772

BREAKING CHANGE: - Ember.js v3.28 or above - Ember CLI v3.28 or above - Node.js v14 or above

velrest force-pushed the ember_v4 branch from ab5ab44 to 12d2772 Compare July 4, 2023 12:59

derrabauke approved these changes Jul 4, 2023

View reviewed changes

velrest merged commit 37cdaed into projectcaluma:main Jul 4, 2023

derrabauke added the released label Jul 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update to ember v4 #625

chore: update to ember v4 #625

velrest commented Jan 25, 2023 •

edited

Loading

velrest commented Jan 25, 2023 •

edited

Loading

velrest commented Jan 26, 2023 •

edited

Loading

velrest commented Jan 26, 2023

velrest commented Jan 27, 2023

derrabauke commented May 1, 2023

derrabauke commented Jun 30, 2023

velrest commented Jun 30, 2023 •

edited

Loading

derrabauke commented Jun 30, 2023

derrabauke commented Jun 30, 2023

velrest commented Jul 4, 2023

derrabauke commented Jul 4, 2023

velrest commented Jul 4, 2023

derrabauke left a comment

derrabauke commented Jul 5, 2023

chore: update to ember v4 #625

chore: update to ember v4 #625

Conversation

velrest commented Jan 25, 2023 • edited Loading

velrest commented Jan 25, 2023 • edited Loading

velrest commented Jan 26, 2023 • edited Loading

velrest commented Jan 26, 2023

velrest commented Jan 27, 2023

derrabauke commented May 1, 2023

derrabauke commented Jun 30, 2023

velrest commented Jun 30, 2023 • edited Loading

derrabauke commented Jun 30, 2023

derrabauke commented Jun 30, 2023

velrest commented Jul 4, 2023

derrabauke commented Jul 4, 2023

velrest commented Jul 4, 2023

derrabauke left a comment

Choose a reason for hiding this comment

derrabauke commented Jul 5, 2023

velrest commented Jan 25, 2023 •

edited

Loading

velrest commented Jan 25, 2023 •

edited

Loading

velrest commented Jan 26, 2023 •

edited

Loading

velrest commented Jun 30, 2023 •

edited

Loading