fix: add ember-data version check to check if calling .toArray on ember-data arrays is deprecated
#2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czosel
reviewed
Oct 5, 2023
czosel
approved these changes
Oct 5, 2023
…mber-data arrays is deprecated
StephanH90
force-pushed
the
fix/add-ember-data-version-check
branch
2 times, most recently
from
05c18b9 to
67baab6
Compare
anehx
requested changes
Oct 27, 2023
StephanH90
force-pushed
the
fix/add-ember-data-version-check
branch
3 times, most recently
from
c992ed2 to
4c90e8f
Compare
anehx
requested changes
Oct 27, 2023
StephanH90
force-pushed
the
fix/add-ember-data-version-check
branch
2 times, most recently
from
24d83e2 to
1deb79c
Compare
StephanH90
force-pushed
the
fix/add-ember-data-version-check
branch
from
1deb79c to
75f3762
Compare
|
I had to downgrade my pnpm to 8.6.0 (I was on 8.8.0 before). Now the lockfile looks right. |
anehx
approved these changes
Oct 27, 2023
anehx
pushed a commit
that referenced
this pull request
Nov 6, 2023
# [12.6.0](v12.5.0...v12.6.0) (2023-11-06) ### Bug Fixes * add ember-data version check to check if calling `.toArray` on ember-data arrays is deprecated ([#2525](#2525)) ([a719961](a719961)) ### Features * **distribution:** pass distribution to abilities functions ([#2538](#2538)) ([1cf1593](1cf1593)) * enable single- and multiple-choice questions in the inquiry preview ([8c97c44](8c97c44))
|
🎉 This PR is included in version 12.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
.toArrayon ember-data arrays is deprecated since[email protected]. Therefore we make the.toArraycall conditional.