When modal is open, turn off body scrolling #3453
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These inline styles are what bootstrap 4 does, discovered through reverse-engineering, although it uses a lot more abstraction to do it. (A ScrollHelper object that can do a lot more things).
This behavior now matches Bootstrap modal behavior, and avoids some weird double scroll within scroll.
Before
Screen.Recording.2024-11-21.at.2.55.47.PM.mov
After
Screen.Recording.2024-11-21.at.2.56.58.PM.mov