Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/1.2.3: New docker base image #55

Merged
merged 5 commits into from
Jul 21, 2021
Merged

Hotfix/1.2.3: New docker base image #55

merged 5 commits into from
Jul 21, 2021

Conversation

nsoblath
Copy link
Member

The base image is now p8compute_dependencies:v1.0.0, which is based on Ubuntu 20.04 instead of CentOS.

Testing the build locally worked for me.

Copy link
Collaborator

@taliaweiss taliaweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docker image built for me, but when I tried to execute source $MERMITHID_BUILD_PREFIX/setup.sh inside the container, I got an error: bash: python: command not found.
Perhaps that is because it needs python3?

@nsoblath
Copy link
Member Author

nsoblath commented Jul 1, 2021

@taliaweiss I think you're right. I changed the use of python in the setup script to python3, and it worked in the test I just ran.

@nsoblath nsoblath requested a review from taliaweiss July 1, 2021 23:55
@taliaweiss
Copy link
Collaborator

Thank you for making that change – sourcing the setup.sh file now works well!

However, when I try to run a termite script (fake_data_stan_analysis.py) in the container, I get the error included below.

I think this is what's happening: morphoorg/morpho#151

  File "fake_data_stan_analysis.py", line 20, in <module>
    from morpho.utilities import morphologging
  File "/usr/local/p8/mermithid/v1.2.2/lib/python3.8/site-packages/morpho/__init__.py", line 24, in <module>
    module = loader.find_module(name).load_module(name)
  File "/usr/local/p8/mermithid/v1.2.2/lib/python3.8/site-packages/morpho/processors/__init__.py", line 7, in <module>
    from . import diagnostics
  File "/usr/local/root/lib/ROOT/_facade.py", line 121, in _importhook
    return _orig_ihook(name, *args, **kwds)
  File "/usr/local/p8/mermithid/v1.2.2/lib/python3.8/site-packages/morpho/processors/diagnostics/__init__.py", line 6, in <module>
    from .CalibrationProcessor import CalibrationProcessor
  File "/usr/local/root/lib/ROOT/_facade.py", line 121, in _importhook
    return _orig_ihook(name, *args, **kwds)
  File "/usr/local/p8/mermithid/v1.2.2/lib/python3.8/site-packages/morpho/processors/diagnostics/CalibrationProcessor.py", line 16, in <module>
    from morpho.processors import BaseProcessor
  File "/usr/local/root/lib/ROOT/_facade.py", line 121, in _importhook
    return _orig_ihook(name, *args, **kwds)
  File "/usr/local/p8/mermithid/v1.2.2/lib/python3.8/site-packages/morpho/processors/__init__.py", line 11, in <module>
    from . import sampling
  File "/usr/local/root/lib/ROOT/_facade.py", line 121, in _importhook
    return _orig_ihook(name, *args, **kwds)
  File "/usr/local/p8/mermithid/v1.2.2/lib/python3.8/site-packages/morpho/processors/sampling/__init__.py", line 11, in <module>
    from .PyBindRooFitProcessor import PyBindRooFitProcessor
  File "/usr/local/root/lib/ROOT/_facade.py", line 121, in _importhook
    return _orig_ihook(name, *args, **kwds)
  File "/usr/local/p8/mermithid/v1.2.2/lib/python3.8/site-packages/morpho/processors/sampling/PyBindRooFitProcessor.py", line 22, in <module>
    class PyFunctionObject(ROOT.TPyMultiGenFunction):
  File "/usr/local/root/lib/ROOT/_facade.py", line 163, in _fallback_getattr
    raise AttributeError("Failed to get attribute {} from ROOT".format(name))
AttributeError: Failed to get attribute TPyMultiGenFunction from ROOT

@cclaessens
Copy link
Contributor

cclaessens commented Jul 2, 2021

I get the same error as Talia. Is it possible that PyROOT is still build for python 2 instead of 3?
During building I get several warnings from morpho. Do we have to make the python and/or pip version change in morpho too?

@taliaweiss taliaweiss merged commit cee1ce5 into master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants