Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference the global bucket variable in the Helm chart #79

Open
wants to merge 2 commits into
base: release-7.0.0
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helmcharts/knowledgebb/charts/flink/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ base_config: |
blob {
storage {
account = "{{ .Values.global.azure_storage_account_name }}.blob.core.windows.net"
container = "flink-check-points-store"
container = "{{ .Values.global.azure_public_container_name }}"
checkpointing.dir = "checkpoint"
}
}
Expand Down
4 changes: 2 additions & 2 deletions helmcharts/learnbb/charts/flink/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ taskmanager:

# Azure Container Details
checkpoint_store_type: "azure"
cloud_storage_flink_bucketname: {{ .Values.global.azure_flink_state_container_name }}
cloud_storage_flink_bucketname: "{{ .Values.global.azure_flink_state_container_name }}"

# AWS S3 Details
s3_access_key: ""
Expand Down Expand Up @@ -365,7 +365,7 @@ base_config: |
{{- else if eq .Values.checkpoint_store_type "s3" -}}
"{{- .Values.flink_dp_storage_container }}"
{{- end }}
container = "{{ .Values.cloud_storage_flink_bucketname }}"
container = "{{ .Values.global.azure_flink_state_container_name }}"
checkpointing.dir = "checkpoint"
}
}
Expand Down
2 changes: 1 addition & 1 deletion helmcharts/obsrvbb/charts/etl-jobs/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -89,5 +89,5 @@ cassandra:
old_table: "device_profile"
new_table: "device_profile_temp"

container_name: {{ .Values.global.azure_telemetry_container_name }}
container_name: "{{ .Values.global.azure_telemetry_container_name }}"
object_key: "druid-content-snapshot/snapshot.txt"
4 changes: 2 additions & 2 deletions helmcharts/obsrvbb/charts/flink/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ azure_secret: "azure-secret"

# Azure Container Details
checkpoint_store_type: "azure"
cloud_storage_flink_bucketname: {{ .Values.global.azure_flink_state_container_name }}
cloud_storage_flink_bucketname: "{{ .Values.global.azure_flink_state_container_name }}"
cloud_storage_content_bucketname: sunbird-content-dev
cert_container_name: dev-e-credentials
cloud_storage_endpoint: https://{{ .Values.global.azure_storage_account_name }}.blob.core.windows.net
Expand Down Expand Up @@ -287,7 +287,7 @@ base_config: |
blob {
storage {
account = "{{ .Values.global.azure_storage_account_name }}.blob.core.windows.net"
container = "{{ .Values.container }}"
container = "{{ .Values.global.azure_flink_state_container_name }}"
checkpointing.dir = "checkpoint"
}
}
Expand Down
9 changes: 1 addition & 8 deletions terraform/azure/modules/keys/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,4 @@ variable "rsa_keys_count" {
default = 2
}

variable "random_string" {
type = string
description = "This string will be used to encrypt / mask various values. Use a strong random string in order to secure the applications. The string should be between 12 and 24 characters in length. If you forget the string, the application will stop working and the string cannot be retrieved."
validation {
condition = length(var.random_string) >= 12 || length(var.random_string) <= 24
error_message = "The string must have a length ranging from 12 to 24 characters."
}
}

2 changes: 1 addition & 1 deletion terraform/azure/modules/output-file/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ content = templatefile("${path.module}/global-cloud-values.yaml.tfpl", {
azure_dial_state_container_name = var.dial_state_container_public,
azure_telemetry_container_name = var.telemetry_container_private,
private_ingressgateway_ip = var.private_ingressgateway_ip,
encrypted_string = var.encryption_string,
encryption_string = var.encryption_string,
random_string = var.random_string
})
filename = local.global_values_cloud_file
Expand Down
4 changes: 2 additions & 2 deletions terraform/azure/template/install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ function install_helm_components() {
}

function dns_mapping() {
domain_name=$(kubectl get cm -n sunbird report-env -ojsonpath='{.data.SUNBIRD_ENV}')
domain_name=$(kubectl get cm -n sunbird lms-env -ojsonpath='{.data.sunbird_web_url}')
PUBLIC_IP=$(kubectl get svc -n sunbird nginx-public-ingress -ojsonpath='{.status.loadBalancer.ingress[0].ip}')

local timeout=$((SECONDS + 1200))
Expand Down Expand Up @@ -133,7 +133,7 @@ function generate_postman_env() {
if [ "$(basename $current_directory)" != "$environment" ]; then
cd ../terraform/azure/$environment 2>/dev/null || true
fi
domain_name=$(kubectl get cm -n sunbird report-env -ojsonpath='{.data.SUNBIRD_ENV}')
domain_name=$(kubectl get cm -n sunbird lms-env -ojsonpath='{.data.sunbird_web_url}')
api_key=$(kubectl get cm -n sunbird player-env -ojsonpath='{.data.sunbird_api_auth_token}')
keycloak_secret=$(kubectl get cm -n sunbird player-env -ojsonpath='{.data.sunbird_portal_session_secret}')
keycloak_admin=$(kubectl get cm -n sunbird userorg-env -ojsonpath='{.data.sunbird_sso_username}')
Expand Down