Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrt. #56
commonBases?: <PublicKey[]>
is a prop that can be passed on to the<Swap>
This will show up on top of the list.
The star icon in the token list lets users select their own custom base token apart from the
customBases
passed as a prop.The icon also acts like a toggle that reflects the state change also updating local storage.
I also fixed unnecessary rerenders of
TokenDialog
. For example it was rendering even when it was not displayed on screen.Hence used the
showTokenDialog
bool to trigger its render only when its shown.This is before using the fix.
This is after we use
useMemo
to only render when the list is shownThis makes the UI a bit faster preventing rerenders. and the UX a little better I hope.
Let me know what you think! :))