Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHCLOUD-34576 Loads both config and command line arguments #39

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

josejulio
Copy link
Contributor

The original fix was using the rootcmd prerun - but that is not
executed when using a sub command. Config was not being loaded at all.

The original bug still aplies, repeated flags are overriden.

The flags are honored just before loading the config from viper. But once
It is loaded the overriden repeated flags are set to the default values.

Adding storage.* flags as PersistentFlags since is used in both commands.

PR Template:

Describe your changes

  • ...

Ticket reference (if applicable)

Fixes #

Checklist

  • Are the agreed upon acceptance criteria fulfilled?

  • Was the 4-eye-principle applied? (async PR review, pairing, ensembling)

  • Do your changes have passing automated tests and sufficient observability?

  • Are the work steps you introduced repeatable by others, either through automation or documentation?

    • If automation is possible but not done due to other constraints, a ticket to the tech debt sprint is added
    • An SOP (Standard Operating Procedure) was created
  • The Changes were automatically built, tested, and - if needed, behind a feature flag - deployed to our production environment. (Please check this when the new deployment is done and you could verify it.)

  • Are the agreed upon coding/architectural practices applied?

  • Are security needs fullfilled? (e.g. no internal URL)

  • Is the corresponding Ticket in the right state? (should be on "review" now, put to done when this change made it to production)

  • For changes to the public API / code dependencies: Was the whole team (or a sufficient amount of ppl) able to review?

  The original fix was using the rootcmd prerun - but that is not
  executed when using a sub command. Config was not being loaded at all.

  The original bug still aplies, repeated flags are overriden.

  The flags are honored just before loading the config from viper. But once
  It is loaded the overriden repeated flags are set to the default values.

  Adding storage.* flags as PersistentFlags since is used in both commands.
@josejulio josejulio merged commit e001c36 into project-kessel:main Aug 16, 2024
7 checks passed
@josejulio josejulio deleted the RHCLOUD-34576-b branch August 16, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants