Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SC-Branch Build Support #286

Conversation

casey-williams-rh
Copy link
Contributor

PR Template:

Describe your changes

  • Added support for building a container image based on the Security-Compliance (SC) Branch.
  • Setup all container image builds to be constructed within a /tmp directory.
    • This is to ensure secrets are not accidentally baked into the built image.
  • Removed the build command for ${IMAGE}:latest and replaced it with tag "${IMAGE}:${IMAGE_TAG}" "${IMAGE}:latest"
    • Both build command where building the same image, this will save time during build, as it will now build once, push ${IMAGE}:${IMAGE_TAG}, re-tag the image as ${IMAGE}:latest and push again.

Ticket reference (if applicable)

Checklist

  • Are the agreed upon acceptance criteria fulfilled?

  • Was the 4-eye-principle applied? (async PR review, pairing, ensembling)

  • Do your changes have passing automated tests and sufficient observability?

  • Are the work steps you introduced repeatable by others, either through automation or documentation?

    • If automation is possible but not done due to other constraints, a ticket to the tech debt sprint is added
    • An SOP (Standard Operating Procedure) was created
  • The Changes were automatically built, tested, and - if needed, behind a feature flag - deployed to our production environment. (Please check this when the new deployment is done and you could verify it.)

  • Are the agreed upon coding/architectural practices applied?

  • Are security needs fullfilled? (e.g. no internal URL)

  • Is the corresponding Ticket in the right state? (should be on "review" now, put to done when this change made it to production)

  • For changes to the public API / code dependencies: Was the whole team (or a sufficient amount of ppl) able to review?

@tonytheleg tonytheleg merged commit 45a28e5 into project-kessel:main Jan 9, 2025
8 of 10 checks passed
@casey-williams-rh casey-williams-rh deleted the adding-sc-branch-build-support branch January 9, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants