Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to remove natural_id and make reporterid internal #19

Merged
merged 2 commits into from
Aug 7, 2024
Merged

changes to remove natural_id and make reporterid internal #19

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1dc1405
changes to remove natural_id and make reporterid internal
randymgeorge Aug 7, 2024
922ee6f
update PR
randymgeorge Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions api/kessel/inventory/v1/health_grpc.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions api/kessel/inventory/v1beta1/k8s_clusters_service.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions api/kessel/inventory/v1beta1/k8s_clusters_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ message CreateK8sClusterResponse {

message UpdateK8sClusterRequest {
// The {resource} format
// \"<reporter_data.reporter_type>:<reporter_data.reporter_id>::<reporter_data.resourceId_alias>\".
// \"<reporter_data.reporter_type>:<reporter_data.resourceId_alias>\".
string resource = 1;
// The k8s clsuter to update
K8sCluster k8s_cluster = 2;
Expand All @@ -32,7 +32,7 @@ message UpdateK8sClusterResponse {}

message DeleteK8sClusterRequest {
// The {resource} format
// \"<reporter_data.reporter_type>:<reporter_data.reporter_id>::<reporter_data.resourceId_alias>\".
// \"<reporter_data.reporter_type>:<reporter_data.resourceId_alias>\".
string resource = 1;
}

Expand Down
25 changes: 18 additions & 7 deletions api/kessel/inventory/v1beta1/k8s_clusters_service_grpc.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

79 changes: 34 additions & 45 deletions api/kessel/inventory/v1beta1/metadata.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions api/kessel/inventory/v1beta1/metadata.pb.validate.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions api/kessel/inventory/v1beta1/metadata.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ message Metadata {
// Kessel Asset Inventory generated identifier.
int64 id = 3355 [ (google.api.field_behavior) = OUTPUT_ONLY ];

// Some identifier intrinsic to the resource itself that is unique across reporters
string natural_id = 1;

// The type of the Resource
string resource_type = 442752204;

Expand Down
4 changes: 2 additions & 2 deletions api/kessel/inventory/v1beta1/notifications_integrations_service.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions api/kessel/inventory/v1beta1/notifications_integrations_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ message CreateNotificationsIntegrationResponse {

message UpdateNotificationsIntegrationRequest {
// A resource instance using the format:
// \"<reporter_data.reporter_type>:<reporter_data.reporter_id>::<reporter_data.resourceId_alias>\"
// \"<reporter_data.reporter_type>:<reporter_data.resourceId_alias>\"
string resource = 1 [
(google.api.field_behavior) = REQUIRED
];
Expand All @@ -41,7 +41,7 @@ message UpdateNotificationsIntegrationResponse {}

message DeleteNotificationsIntegrationRequest {
// A resource instance using the format:
// \"<reporter_data.reporter_type>:<reporter_data.reporter_id>::<reporter_data.resourceId_alias>\"
// \"<reporter_data.reporter_type>:<reporter_data.resourceId_alias>\"
string resource = 1 [
(google.api.field_behavior) = REQUIRED
];
Expand Down
Loading
Loading