-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHCLOUD-35286: Ensure log verbosity can be adjusted #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adam0Brien
force-pushed
the
change-log-verb
branch
2 times, most recently
from
September 23, 2024 15:39
22b78f0
to
e26d346
Compare
Adam0Brien
force-pushed
the
change-log-verb
branch
from
September 23, 2024 16:22
e26d346
to
a7c62f2
Compare
akoserwal
reviewed
Sep 25, 2024
Adam0Brien
force-pushed
the
change-log-verb
branch
from
September 26, 2024 15:03
0e84fc7
to
e2931b5
Compare
Adam0Brien
force-pushed
the
change-log-verb
branch
from
September 27, 2024 07:30
20e4031
to
db239cf
Compare
Adam0Brien
force-pushed
the
change-log-verb
branch
from
September 30, 2024 08:39
e3860d7
to
4a500ba
Compare
akoserwal
reviewed
Sep 30, 2024
Adam0Brien
force-pushed
the
change-log-verb
branch
from
September 30, 2024 09:08
b3a6ee9
to
e62c82c
Compare
Adam0Brien
force-pushed
the
change-log-verb
branch
from
September 30, 2024 09:10
e62c82c
to
54bb577
Compare
Adam0Brien
force-pushed
the
change-log-verb
branch
from
September 30, 2024 10:32
28f2dcd
to
308df28
Compare
akoserwal
reviewed
Sep 30, 2024
@@ -99,13 +94,17 @@ func init() { | |||
options.Storage.Postgres.DbName = clowder.LoadedConfig.Database.Name | |||
} | |||
|
|||
migrateCmd := migrate.NewCommand(options.Storage, log.With(rootLog, "group", "storage")) | |||
initConfig() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why call initConfig
?
Adam0Brien
force-pushed
the
change-log-verb
branch
from
September 30, 2024 12:50
6856261
to
4cb7b4d
Compare
akoserwal
approved these changes
Sep 30, 2024
Adam0Brien
force-pushed
the
change-log-verb
branch
from
October 1, 2024 07:40
5221534
to
e8e4bbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Template:
Describe your changes
inventory-api-compose
e.g.
Steps:
inventory-api-compose.yaml
Log Level is set to: warn ERROR ts=2024-09-23T14:31:35Z caller=log/log.go:30 service.name=inventory-api service.version=0.1.0 trace.id= span.id= service.id=738b063b4a09 msg=RELATIONS-API UNHEALTHY ERROR ts=2024-09-23T14:31:35Z caller=log/log.go:30 service.name=inventory-api service.version=0.1.0 trace.id= span.id= service.id=738b063b4a09 msg=RELATIONS-API UNHEALTHY ERROR ts=2024-09-23T14:31:35Z caller=log/log.go:30 service.name=inventory-api service.version=0.1.0 trace.id= span.id= service.id=738b063b4a09 msg=RELATIONS-API UNHEALTHY
Steps:
inventory-api-compose.yaml
Ticket reference (if applicable)
Fixes #RHCLOUD-35286
Checklist
Are the agreed upon acceptance criteria fulfilled?
Was the 4-eye-principle applied? (async PR review, pairing, ensembling)
Do your changes have passing automated tests and sufficient observability?
Are the work steps you introduced repeatable by others, either through automation or documentation?
The Changes were automatically built, tested, and - if needed, behind a feature flag - deployed to our production environment. (Please check this when the new deployment is done and you could verify it.)
Are the agreed upon coding/architectural practices applied?
Are security needs fullfilled? (e.g. no internal URL)
Is the corresponding Ticket in the right state? (should be on "review" now, put to done when this change made it to production)
For changes to the public API / code dependencies: Was the whole team (or a sufficient amount of ppl) able to review?