Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional filter #43

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vpawar-tibco
Copy link

Added support to provide custom filter conditions in filter activity.
Example usage - Filter all streams which meets certain condition e.g input value > threshold, input string contains keyword substring.

@flogo-oss
Copy link
Contributor

flogo-oss commented Jun 26, 2020

CLA assistant check
All committers have signed the CLA.

@fm-tibco fm-tibco self-requested a review June 26, 2020 14:24
@fm-tibco
Copy link

fm-tibco commented Jun 26, 2020

Hi @vpawar-ai, just to clarify, does "condition" is true just filter the specified value. When I think "condition" I think of an expression instead of a boolean. Should we let condition be string and options are "<,>,==,<=,>=, !=" ?

@vpawar-tibco
Copy link
Author

Hi @fm-tibco, the "condition" input data type is boolean because it is expected that the filter expression evalutes to true or false. Example - for condition expression string.contains($pipeline.input,"keyword"), the activity will filter(skip) all the inputs matching the expression.

@fm-tibco
Copy link

Oh, I see the condition expression is actually external to the activity. You are using the result of a mapping expression and assigning that to the "condition".

It if this the case, I think we should try to come up with an alternative name. Basically when "true" you filter out the value, so make like a "force" or "explict" filter... @mellistibco any thoughts on a possible name for this?

@fm-tibco fm-tibco requested a review from mellistibco July 6, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants