-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #97
Open
nareshkumarthota
wants to merge
140
commits into
master
Choose a base branch
from
develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Develop #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'expr' into noschema
Feature decision table parser
* updated example to use store config file * fixing excelise v2 upgrade * update decisiontable example to work with xlsx file and fix go tests (#82) * update decisiontable example to work with xlsx file and fix go tests * removing duplicated flogo.json from test folder * updated decision table example readme * stabilising mod and sum files
Feature decision table
* Adding travis file with basic configuration Test travis file currently runs go tests and this will be enhanced further * travis file enhancements * updating travis file install latest flogo cli * restructuring travis file * resolving build failure issue with gomodules * fix build failures * pass correct env values to travis file
Merge from master
fixes issue - #91
* Add examples * Updating examples * Updating comments
* dtable code refactoring to support api model * adding dtable ruleapi model example * adding dtable interface * example modified * decision table api model refactored and example modified * Adding Readme * Update Readme * go tests added * code refactoring Co-authored-by: ykalidin <[email protected]>
* Updateing examples * Update Test
* Updating Readme * Update Readme * Updating Readme
rameshpolishetti
requested changes
Apr 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this PR contains several features. It's not a good idea to merge at once, instead break this PR into feature-based PRs and submit one after another.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds following functionality: