-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Neo4j Connector #12
base: master
Are you sure you want to change the base?
Neo4j Connector #12
Conversation
|
||
//FromMap method | ||
func (i *Input) FromMap(values map[string]interface{}) error { | ||
i.CypherQuery, _ = coerce.ToString(values["cypherQuery"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a nitpick, I think you should not ignore error here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you should probably just return the error if it is not nil.
var err error
i.CypherQuery, err = coerce.ToString(values["cypherQuery"])
if err != nil {
return err
}
Rest looks good. |
|
||
//FromMap method | ||
func (i *Input) FromMap(values map[string]interface{}) error { | ||
i.CypherQuery, _ = coerce.ToString(values["cypherQuery"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you should probably just return the error if it is not nil.
var err error
i.CypherQuery, err = coerce.ToString(values["cypherQuery"])
if err != nil {
return err
}
Adding Neo4j Connector -
Features :