Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #117 Specify base go.mod for app creation #119

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

yxuco
Copy link

@yxuco yxuco commented Dec 11, 2020

@lixingwang
Copy link
Contributor

@yxuco This feature only for specifying the version of flow and core right? We do have an option --cv to specify the core version. what exactly the issue or use case you want to achieve here? by exposing go.mod file which too technical for the user I think

@yxuco
Copy link
Author

yxuco commented Jan 4, 2021

--cv is not flexible enough to override other things. For example, I need to build package with shim trigger that requires patches for both flogo/core and flogo/flow versions, as well as changing the module name of the resulting package. It would be simpler to allow a startup mod file that overrides all these attributes, instead of providing multiple flags to override individual attributes such as --cv.

@lixingwang
Copy link
Contributor

@mellistibco thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants