fix: microdnf update #721
Merged
fix: microdnf update #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miaha Cybersec <[email protected]>
MiahaCybersec
requested review from
jeremyrickard,
sozercan and
ashnamehrotra
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #721 +/- ##
=======================================
Coverage 34.22% 34.22%
=======================================
Files 18 18
Lines 1578 1578
=======================================
Hits 540 540
Misses 1007 1007
Partials 31 31 ☔ View full report in Codecov by Sentry. |
|
is there a test we can add for microdnf? |
|
@MiahaCybersec we can add |
added 2 commits
July 29, 2024 12:42
Signed-off-by: Miaha Cybersec <[email protected]>
Signed-off-by: Miaha Cybersec <[email protected]>
|
It looks like the failing test is due to a custom network configuration integration test which failed to pull the Docker image |
|
@MiahaCybersec sometimes the connection is flakey. I re-ran and the test passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microdnf was missing
-yand was not updating correctly.Closes #714