Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add changelog to image label when pushing new versions #56

Merged
merged 10 commits into from
Aug 8, 2024

Conversation

jgrer
Copy link
Collaborator

@jgrer jgrer commented Aug 7, 2024

  • Changed release.yaml to gather the auto generated release notes into release_notes.md
  • Added code to convert release_notes.md into a html file
  • Passed this html file to the dockerfile for the extension using build args
  • Set this html file in string format as the com.docker.extension.changelog parameter

Makefile Outdated Show resolved Hide resolved
jgrer and others added 4 commits August 7, 2024 16:24
Co-authored-by: Ashna Mehrotra <[email protected]>
Signed-off-by: Jackson Greer <[email protected]>
@ashnamehrotra
Copy link
Contributor

@jgrer can we also change the version in the install link in the readme on release? docker extension install projectcopacetic/copacetic-docker-desktop-extension:0.1.0

@jgrer
Copy link
Collaborator Author

jgrer commented Aug 8, 2024

@jgrer can we also change the version in the install link in the readme on release? docker extension install projectcopacetic/copacetic-docker-desktop-extension:0.1.0

removed the example of the install command (not worth to update) and updated the link to point to the latest version of the extension

@jgrer jgrer requested a review from ashnamehrotra August 8, 2024 18:13
Copy link
Contributor

@ashnamehrotra ashnamehrotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashnamehrotra ashnamehrotra merged commit 96bb257 into project-copacetic:main Aug 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants