-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support for buildx #37
Merged
ashnamehrotra
merged 22 commits into
project-copacetic:main
from
ashnamehrotra:support-for-buildx-2
Feb 20, 2024
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
c7396d5
enable support for buildx
ashnamehrotra ad52fa1
modify build test
ashnamehrotra e8b770a
allow for custom socket input and clean code
ashnamehrotra 25154c4
remove teardown from test
ashnamehrotra 6efdf56
code cleanup and documentation
ashnamehrotra f830a72
syntax fix
ashnamehrotra 968487f
add clarification after testing - ctr d img store approach outputs to…
ashnamehrotra 113ed58
add clarification for buildkit version
ashnamehrotra 6b2efca
add note markers
ashnamehrotra a3ccdac
fix build test
ashnamehrotra 09a5f0f
fix ordering for output arg
ashnamehrotra e172609
change order in build test
ashnamehrotra eae67bb
fix order
ashnamehrotra 74dbb7d
changes so far
ashnamehrotra 36ab31d
add other two tests back
ashnamehrotra c09a51b
cleanup
ashnamehrotra f26cc30
more cleanup
ashnamehrotra de775c2
save patched image as tar file
ashnamehrotra cae27f1
only change context for custom socket
ashnamehrotra 17b14e5
remove nginx test from patch also
ashnamehrotra bf6f004
add note for tarball
ashnamehrotra 7fb5acf
clarify README
ashnamehrotra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
only change context for custom socket
Signed-off-by: ashnamehrotra <[email protected]>
- Loading branch information
commit cae27f15fd76a1349a0f0eeca5d7e4adaf75949b
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we saving to a tarball? because trivy can't scan it? if so, can you add a note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I did some research but I couldn't find a way to get trivy access without saving to tarball. Added a note for that!