Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'inline' from the destructor #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove 'inline' from the destructor #53

wants to merge 1 commit into from

Conversation

danilcha
Copy link

@danilcha danilcha commented Feb 9, 2018

When compiling with GCC using -Winline the compiler warns that the call to the destructor will not be inlined (I use ThreadPool in multiple places):

ThreadPool/ThreadPool.h:87:8: warning: inlining failed in call to 
‘ThreadPool::~ThreadPool() noexcept’: call is unlikely and code size would grow [-Winline]
 inline ThreadPool::~ThreadPool()

Besides, there is no reason in inline here. Removing it.

@jhasse
Copy link

jhasse commented Apr 18, 2018

I hope you're okay with that I cherry-picked your commit on my fork: jhasse@5c54162 :)

@danilcha
Copy link
Author

Sure! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants