Debug #1946 #2007
Draft
Debug #1946 #2007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be some kind of standard script name for bootstrapping autotools. Signed-off-by: Steffen Jaeckel <[email protected]>
This reverts commit d7e46d6.
They're only used in `window.c`. Signed-off-by: Steffen Jaeckel <[email protected]>
This creates a "as personal as possible" Valgrind suppressions file. Signed-off-by: Steffen Jaeckel <[email protected]>
Add all elements to an array, in order to easily be able to run operations in bulk. Signed-off-by: Steffen Jaeckel <[email protected]>
`Py_Initialize()` does it since 3.7, it's a noop and deprecated since 3.9. https://docs.python.org/3/c-api/init.html#c.PyEval_InitThreads Signed-off-by: Steffen Jaeckel <[email protected]>
Signed-off-by: Steffen Jaeckel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a starting point while debugging #1946.
The memory usage on current develop has increased significantly since 0.14.0.
The main memory saving was done by reverting d7e46d6 which is not in 0.14.0.
I did not yet conclude on what the real problem is, but my guess is that the memory growth can only be tackled by rewriting some internal parts and we're not really leaking memory. AFAICT most memory is accounted for and is free'd on program termination.
NB: The valgrind output of a default build, executed with "our default valgrind settings" is kind of misleading. Each time a gnupg API is invoked it forks which causes the valgrind output to blow up and be hard to analyze. One way to improve the debug experience would be to disable following forks when running valgrind, another is to disable gnupg.
I've extended our default
prof.suppby quite a bit, which must still be reviewed whether those excludes should be there or not.