Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: group dependabot updates when minor/patch #74

Closed

Conversation

jmeridth
Copy link
Contributor

@jmeridth jmeridth commented Jun 4, 2024

  • change dependabot config to group dependencies
    • leave major dependency updates to their own PR so they stand out and are tested correctly
    • prefix the PRs with chore(deps) to adhere to conventional commits
  • change GitHub Actions to use SHAs instead of tags
    • Why?
      • To prevent supply chain attack. Tags can move. They are mutable. SHAs are not.
    • used frizbee
      • ran frizbee ghactions -d .github/workflows locally
      • also fixes formatting

Checklist:

  • I have updated the necessary documentation
  • I have signed off all my commits as required by DCO
  • My build is green

@jmeridth jmeridth requested review from a team as code owners June 4, 2024 23:56
@jmeridth jmeridth force-pushed the jm_group_dependency_updates branch 2 times, most recently from 5dcf7d3 to 7e5b06f Compare June 5, 2024 22:25
- [x] change dependabot config to group dependencies
  - leave major dependency updates to their own PR so they stand out and are tested correctly
  - prefix the PRs with `chore(deps)` to adhere to conventional commits
- [x] change GitHub Actions to use SHAs instead of tags
  - used [frizbee](https://github.com/stacklok/frizbee)
    - ran `frizbee ghactions -d .github/workflows` locally
    - also fixes formatting

Signed-off-by: jmeridth <[email protected]>
@jmeridth jmeridth force-pushed the jm_group_dependency_updates branch from 7e5b06f to 9790f49 Compare June 5, 2024 22:26
Copy link

github-actions bot commented Aug 6, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@jmeridth jmeridth closed this Aug 12, 2024
@jmeridth jmeridth deleted the jm_group_dependency_updates branch August 12, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant