Allow a V2 view to specify its parent, regardless of how it's nested #487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been thinking about an "impendance mismatch" between V1 and V2 that will make upgrading more difficult (whether manual or scripted). This is an attempt to patch over a common case. I'm not 100% sold on it myself - I'd like to keep the DSL as simple as possible. Feedback welcome.
Consider the following V1 Blueprint:
There are currently two ways to represent this in V2: inheritance and partials.
What this PR adds
This PR allows a view to specify which view it should inherit from, without affecting the name:
Maybe a better idea??
Note that the above doesn't address cases where V1 views inherit from multiple views. Those would still need to resort to partials. What if every view implicitly defined a partial for itself? 🤯 I think that would solve everything. Much simpler to implement, too.