Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Background
Fixes #443
There's been a longstanding implicit dependency on the standard
json
library, asBlueprinter::Configuration
requires it to be available in the case where a separate JSON library isn't specified on configuration. This hasn't caused many issues in the past, as most use cases forBlueprinter
are in environments wherejson
is loaded (e.g. a Rails application).However, this is a brittle dependency, and if we're explicitly defining a default, we should make sure it's available in the confines of the class that needs it.
Changelog
require 'json'
withinBlueprinter::Configuration
.require 'json'
from specs.