Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to 1.0.2 changelog about breaking change #413

Merged
merged 1 commit into from
May 2, 2024

Conversation

njbbaer
Copy link
Contributor

@njbbaer njbbaer commented Apr 30, 2024

See: #411

@njbbaer njbbaer self-assigned this Apr 30, 2024
@njbbaer njbbaer requested review from ritikesh and a team as code owners April 30, 2024 20:24
Copy link
Contributor

@jmeridth jmeridth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@njbbaer looks like you need to sign your commit (git commit -s), otherwise LGTM

Co-authored-by: Nate Baer <[email protected]>
Signed-off-by: Jacob Sheehy <[email protected]>
@lessthanjacob lessthanjacob force-pushed the nb/update-changelog-1.0.2 branch from 26b12d6 to b9e8de2 Compare May 2, 2024 13:43
@lessthanjacob lessthanjacob requested a review from jmeridth May 2, 2024 13:43
@lessthanjacob lessthanjacob merged commit e609857 into main May 2, 2024
7 checks passed
@lessthanjacob lessthanjacob deleted the nb/update-changelog-1.0.2 branch May 2, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants