-
Notifications
You must be signed in to change notification settings - Fork 27
Conversation
π¦ Changeset detectedLatest commit: 0d24e95 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5bcc3a9
to
d1cf016
Compare
Signed-off-by: Kurt King <[email protected]>
d1cf016
to
bbf918a
Compare
b265471
to
734bf25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, added some comments, not big expert on mui themes so just adding my 2cents of what i could spot
the docs are still referring to mui 5 here:
@@ -64,11 +64,11 @@ | |||
"@backstage/plugin-search-common": "^1.2.15", | |||
"@backstage/plugin-search-react": "^1.8.3", | |||
"@backstage/plugin-signals-react": "^0.0.7", | |||
"@backstage/theme": "^0.5.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the reverted version but we could check if there is a new version right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we could, but I thought it would be best to revert 1:1, and then use the backstage-cli to get us to latest version.
d5d3153
to
c312664
Compare
Signed-off-by: Kurt King <[email protected]>
c312664
to
35aa6a0
Compare
Signed-off-by: Kurt King <[email protected]>
Signed-off-by: Kurt King <[email protected]>
Summary π°
This PR reverts #455.
Checklist β