Skip to content
This repository has been archived by the owner on Dec 27, 2024. It is now read-only.

Revert back to MUI v4 #524

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Revert back to MUI v4 #524

merged 4 commits into from
Dec 20, 2024

Conversation

kurtaking
Copy link
Contributor

@kurtaking kurtaking commented Dec 16, 2024

Summary πŸ“°

This PR reverts #455.

Checklist βœ…

  • I have updated the necessary documentation
  • I have signed off all my commits as required by DCO
  • My build is green

@kurtaking kurtaking self-assigned this Dec 16, 2024
Copy link

changeset-bot bot commented Dec 16, 2024

πŸ¦‹ Changeset detected

Latest commit: 0d24e95

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@procore-oss/backstage-plugin-announcements Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kurtaking kurtaking force-pushed the revert-mui-v5-to-mui-v4 branch 2 times, most recently from 5bcc3a9 to d1cf016 Compare December 16, 2024 04:13
Signed-off-by: Kurt King <[email protected]>
Copy link

@Sarabadu Sarabadu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, added some comments, not big expert on mui themes so just adding my 2cents of what i could spot

the docs are still referring to mui 5 here:

https://github.com/procore-oss/backstage-plugin-announcements/pull/455/files#diff-800400b65b3ab1b16e5870462d6bc86c0980e25e67cd67bcf18d44b65266eebcL94

.yarn/plugins/@yarnpkg/plugin-workspace-tools.cjs Outdated Show resolved Hide resolved
@@ -64,11 +64,11 @@
"@backstage/plugin-search-common": "^1.2.15",
"@backstage/plugin-search-react": "^1.8.3",
"@backstage/plugin-signals-react": "^0.0.7",
"@backstage/theme": "^0.5.7",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the reverted version but we could check if there is a new version right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we could, but I thought it would be best to revert 1:1, and then use the backstage-cli to get us to latest version.

@kurtaking kurtaking force-pushed the revert-mui-v5-to-mui-v4 branch 3 times, most recently from d5d3153 to c312664 Compare December 20, 2024 04:08
@kurtaking kurtaking force-pushed the revert-mui-v5-to-mui-v4 branch from c312664 to 35aa6a0 Compare December 20, 2024 04:30
@kurtaking kurtaking merged commit d773dcb into main Dec 20, 2024
5 checks passed
@kurtaking kurtaking deleted the revert-mui-v5-to-mui-v4 branch December 20, 2024 04:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants