Merge pull request spyder-ide#23316 from ccordoba12/issue-23313

PR: Prevent Chinese input method to block edit input area
procitec · Dec 19, 2024 · 3f64ee3 · 3f64ee3
2 parents 49e81ef + ceb7edd
commit 3f64ee3
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 3 deletions.
diff --git a/spyder/plugins/ipythonconsole/widgets/control.py b/spyder/plugins/ipythonconsole/widgets/control.py
@@ -50,7 +50,8 @@ def __init__(self, parent=None):
         # To not use Spyder calltips obtained through the monitor
         self.calltips = False
 
-    # ---- Public methods ----------------------------------------------------
+    # ---- Public methods
+    # -------------------------------------------------------------------------
     def insert_horizontal_ruler(self):
         """
         Insert a horizontal ruler with the appropriate color according
@@ -69,7 +70,8 @@ def insert_horizontal_ruler(self):
         cursor.movePosition(cursor.End)
         cursor.insertFrame(ruler)
 
-    # ---- Private methods ---------------------------------------------------
+    # ---- Private methods
+    # -------------------------------------------------------------------------
     def _key_paren_left(self, text):
         """ Action for '(' """
         self.current_prompt_pos = self.parentWidget()._prompt_pos
@@ -79,7 +81,8 @@ def _key_paren_left(self, text):
                 self.show_object_info(last_obj)
         self.insert_text(text)
 
-    # ---- Qt methods --------------------------------------------------------
+    # ---- Qt methods
+    # -------------------------------------------------------------------------
     def showEvent(self, event):
         """Reimplement Qt Method"""
         self.sig_visibility_changed.emit(True)

diff --git a/spyder/widgets/mixins.py b/spyder/widgets/mixins.py
@@ -1539,6 +1539,28 @@ def mouseDoubleClickEvent(self, event):
         elif isinstance(self, QTextEdit):
             QTextEdit.mouseDoubleClickEvent(self, event)
 
+    def inputMethodQuery(self, query):
+        """
+        Prevent Chinese input method to block edit input area.
+
+        Notes
+        -----
+        This was suggested by a user in spyder-ide/spyder#23313. So, it's not
+        tested by us.
+        """
+        if query == Qt.ImInputItemClipRectangle:
+            cursor_rect = self.cursorRect()
+            margins = self.viewportMargins()
+            cursor_rect.moveTopLeft(
+                cursor_rect.topLeft() + QPoint(margins.left(), margins.top())
+            )
+            return cursor_rect
+
+        if isinstance(self, QPlainTextEdit):
+            QPlainTextEdit.inputMethodQuery(self, query)
+        elif isinstance(self, QTextEdit):
+            QTextEdit.inputMethodQuery(self, query)
+
 
 class TracebackLinksMixin(object):
     """Mixin to make file names in tracebacks and anchors clickable."""