Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let extended queries handle empty responses #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

oxpa
Copy link

@oxpa oxpa commented Aug 11, 2020

Some queries return empty data sets. In case extended query mechanism was used - whole process would be hung in a 'receive' with no results.
This patch lets p1_pgsql handle such queries and return back to 'ready for query' state.

@p1bot
Copy link
Collaborator

p1bot commented Aug 11, 2020

Hi @oxpa, many thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@p1bot p1bot added the cla-missing Contributor needs to sign Contribution License Agreement label Aug 11, 2020
@p1bot
Copy link
Collaborator

p1bot commented Aug 11, 2020

You did it @oxpa!

Thank you for signing the ProcessOne Contribution License Agreement.

We will have a look at your contribution!

@p1bot p1bot removed the cla-missing Contributor needs to sign Contribution License Agreement label Aug 11, 2020
@badlop
Copy link
Member

badlop commented Aug 13, 2020

This library is used by ejabberd, and its tests didn't report any problem.

@oxpa
Copy link
Author

oxpa commented Aug 13, 2020

I've submitted a pull request to ejabberd to use this patch.
But by the time I made it there was an alternative implementation using E'' syntax. I'm not really sure which approach is better because this uses anonymous prepared statement under the hood and I know to little about E'' escaping in postgres to make educated comparison.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants