[p5.js 2.0] Color module rewrite #7406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davepagurek @ksen0 Here's an example HDR sketch with the HDR renderer: https://editor.p5js.org/limzykenneth/sketches/LB2vJFdj4 You'd need a HDR display to be able to properly view the sketch (eg. iPhone or newer Macs on Safari or Chrome). |
|
Almost done with color.js based implementation. Created another sketch to show comparison of hue wheel of HSL, LCH, and okLCH colors: https://editor.p5js.org/limzykenneth/sketches/66VHrGzCo okLCH is noticeably better at accurate hue angles, eg. see where the primaries RGB are located on the wheel and the distribution of their intermediate colors. |
Browsers still don't generally support `color(--hsv)` syntax so will necessitate conversion. There may be slight difference between old HSB implementation and color.js HSV implementation.
limzykenneth
commented
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite color module based on findings in #7374 and enable HDR color support in 2D canvas.