Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch-CORNER-descr-cx #7062

Merged
merged 3 commits into from
May 21, 2024
+1 −1
Merged

Patch-CORNER-descr-cx #7062

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cda061b
Corrects the description of the CORNER attribute
JulioGitLab May 20, 2024
4892c6f
Corrects the description of the CORNER attribute
JulioGitLab May 20, 2024
58539ee
Revert "Corrects the description of the CORNER attribute"
JulioGitLab May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/shape/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import * as constants from '../constants';
* By default, the first two parameters of
* <a href="#/p5/ellipse">ellipse()</a>, <a href="#/p5/circle">circle()</a>,
* and <a href="#/p5/arc">arc()</a>
* are the x- and y-coordinates of the shape's center. The next parameters set
* are the x- and y-coordinates of the shape's upper left corner. The next parameters set
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickmcintyre do you know if this one needed correcting? Looks like it's the center in the current docs https://p5js.org/reference/#/p5/ellipse so ellipse might be good as is

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per my tests, the x and y coordinates of ellipse() determine the position of the center of the figure by default, so its description is accurate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I see the problem now. This is the first time I create a pull request and seems like I created commit 4892c6f by mistake. I only meant to commit cda061b

Is there a way I can delete 4892c6f so only the right one gets pulled?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem! If you run git revert 4892c6f and push the results, then the Files Changed tab on the PR will only show the changes from cda061b.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I run that command somewhere from GitHub? I used Codespaces to make those commits. Can you please send me some quick steps on how to do it? Thanks for the help

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah looks like you got it!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think so lol. Is there something else I should do?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be good, I'm just waiting for tests to pass and then I'll merge if they look good! (and they should since its just a change to the reference text.)

Copy link
Contributor Author

@JulioGitLab JulioGitLab May 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! It is a very simple contribution, but because it is my first in some way it is special for me haha. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we appreciate it!

* the shape's width and height. This is the same as calling
* `ellipseMode(CENTER)`.
*
Expand Down Expand Up @@ -186,7 +186,7 @@ p5.prototype.noSmooth = function() {
*
* By default, the first two parameters of
* <a href="#/p5/rect">rect()</a> and <a href="#/p5/square">square()</a>,
* are the x- and y-coordinates of the shape's center. The next parameters set
* are the x- and y-coordinates of the shape's upper left corner. The next parameters set
* the shape's width and height. This is the same as calling
* `rectMode(CORNER)`.
*
Expand Down