-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default values of arguments && modernize some code #6807
Default values of arguments && modernize some code #6807
Conversation
789327f
to
9f0e406
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment inline and one more thing which is that there are some inconsistency in terms of space before parenthesis after the function
key word, ie
function ()
// or
function()
For most of the rest of the code base, the consistent use is not having the space so I tend towards that. @nickmcintyre I can't find specific recommendation for this in the documentation style guide, do you have some thoughts on this?
@limzykenneth consistency with no space Longer term, both Airbnb and StandardJS suggest space before parentheses for anonymous functions. Maybe we can revisit style guides on the road to 2.0. |
I'll do a final review later today to see if private methods will work or not. After that I will merge this. |
The new syntax doesn't seem to work with browserify, we'll re-explore this as part of 2.0. I'll merge this for now. Thanks @asukaminato0721 |
|
Resolves #6721
Changes:
use default values of arguments, fix some missing
...args
, use some native apis.Screenshots of the change:
PR Checklist
npm run lint
passes