-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding metallic feature in p5.js for both IBL and non-IBL codes. #6618
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
249ba2b
Adding metalness() function in p5
perminder-17 98d6248
fixed failing test.js
perminder-17 0c6b97b
docs.js
perminder-17 75dfefa
fixes.js
perminder-17 6c50096
fixes.glsl
perminder-17 383f7a4
fixes
perminder-17 deaf539
fixes
perminder-17 665783e
fixes
perminder-17 5c8b04a
fixes
perminder-17 1a65ffa
fixes
perminder-17 4d1982f
fix testFail
perminder-17 b2c3c71
fixes
perminder-17 bbf5868
fixes
perminder-17 324f18e
fixes
perminder-17 ddb69cd
fixes
perminder-17 5bd10ce
fixes
perminder-17 c09b677
fixes
perminder-17 c8d3011
fixes
perminder-17 b06b016
fixes
perminder-17 fba2818
fixes in shaders
perminder-17 dc5c4f2
working tests
perminder-17 0ad6575
lint fix
perminder-17 1e1f91d
test fixes
perminder-17 a2f1342
fixes .every
perminder-17 846d542
docs
perminder-17 0d4b700
indentation fix
perminder-17 cc8dce4
docs
perminder-17 c001e10
Merge branch 'processing:main' into add-metalnness
perminder-17 dbe3363
docs fixes
perminder-17 c27b9de
minor fixes
perminder-17 a9f5a3e
Update material.js
perminder-17 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line also looks like the indentation is a tad off
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the arguments to this function still need to be indented once more