Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made a new method to return Geometry with no internal colors. #6498

Merged
merged 11 commits into from
Oct 26, 2023
Merged

Made a new method to return Geometry with no internal colors. #6498

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d9370c1
ClearColors method applied
perminder-17 Oct 26, 2023
716554f
Update p5.Geometry.js
perminder-17 Oct 26, 2023
e33224a
Removed method from 3D_primitives.js
perminder-17 Oct 26, 2023
df35dc0
Update p5.Geometry.js
perminder-17 Oct 26, 2023
f79a6f2
Update p5.Geometry.js
perminder-17 Oct 26, 2023
8d04276
Update p5.Geometry.js
perminder-17 Oct 26, 2023
bf98913
Update p5.Geometry.js
perminder-17 Oct 26, 2023
341d692
Update p5.Geometry.js
perminder-17 Oct 26, 2023
0791f46
Update p5.Geometry.js
perminder-17 Oct 26, 2023
c997c45
Update p5.Geometry.js
perminder-17 Oct 26, 2023
92c90d1
Update p5.Geometry.js
perminder-17 Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/webgl/p5.Geometry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ p5.Geometry = class Geometry {
/**
* Removes the internal Colors of p5.Geometry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add one more sentence after this explaining that this lets you supply new colors with fill() before drawing it? And otherwise, fill() gets ignored?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I was also thinking of that... Okay going to add this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other small request: could we add a period at the end of the sentence so it fits with the style of the next bit of text? other than that I think everything looks good!

* Using clearColors, you can use 'fill()' to supply new colors before drawing each shape.
* If clearColors() is not used, the shapes will use their internal colors.
* If clearColors() is not used, the shapes will use their internal colors by ignoring 'fill()'.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use backticks around the function names, they'll get rendered like code:

by ignoring `fill()`.

...becomes:

by ignoring fill().

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay...gonna do it.

*
* @method clearColors
*
Expand Down
Loading