new PR for issue #6383(Problem for diagonal)

[perminder-17]

Resolves #6383

Changes:
This is the new pull request after changes and doing it inline.

Screenshots of the change:

before:

after:

It's working perfectly after the changes.

PR Checklist

• npm run lint passes

• Inline documentation is included / updated

• Unit tests are included / updated

[perminder-17]

Dear @davepagurek , I have created a new pull request for this. Thank you for your suggestion. Since the _makeQuadEdges() function is used only once in the code, there is no need to include it in the p5.Geometry class. Best practice dictates that we keep it inline.

[davepagurek]

Thanks @perminder-17! I think the code looks good, I'm just having p5 run its automated test suite to make sure nothing else has broken by accident.

For the future, you don't need to open a new PR to make changes, you can just continue to push commits to your existing one and we can re-review it after that. Don't worry about it for this one though, I can continue reviewing on this one!

[davepagurek]

Cool, looks like tests pass! Thanks for your work on this!

[davepagurek]

@all-contributors please add @perminder-17 for code

[perminder-17]

Thanks @perminder-17! I think the code looks good, I'm just having p5 run its automated test suite to make sure nothing else has broken by accident.

For the future, you don't need to open a new PR to make changes, you can just continue to push commits to your existing one and we can re-review it after that. Don't worry about it for this one though, I can continue reviewing on this one!

Sorry @davepagurek , I got your point. Now i am going to commit changes on existing PR. and sorry for that semicolon though. I don't know how i missed :)

[allcontributors]

@davepagurek

I've put up a pull request to add @perminder-17! 🎉

[perminder-17]

@all-contributors please add @perminder-17 for code

Hey, thankyou for adding me up.

[allcontributors]

@perminder-17

@perminder-17 already contributed before to code

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.