-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add before/after preload and setup #6433
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
2543102
add hooks
capGoblin 50163a2
Refactor hooks
capGoblin 6b16199
add callRegisteredHooksFor
capGoblin 25d9cb4
corrected a typo
capGoblin 6bb0e6f
update callRegisteredHooksFor to use context
capGoblin 5514eaa
use callRegisteredHooksFor for pre/post draw
capGoblin fa06c9c
isGlobal is not read inside callRegisteredHooksFor
capGoblin ff32bbd
fix tests fails
capGoblin a9394b7
add tests for hooks
capGoblin c0d6349
refactor the tests
capGoblin 670cbda
Merge branch 'processing:main' into add-hooks
capGoblin f2aec47
update docs
capGoblin b09e55a
Merge branch 'add-hooks' of https://github.com/capGoblin/p5.js into a…
capGoblin e872ad6
Merge branch 'processing:main' into add-hooks
capGoblin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, looks like tests are failing because
this
is undefined. You might need to make this a method onp5.prototype
and then callthis.callRegisteredHooksFor(...)
as a method instead of a function?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your help!