-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FES] Replace throw error with FES #6098
Conversation
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
The original issue only recommended replacing |
@limzykenneth Thanks for your feedback. Will update this PR! |
Hi @limzykenneth , please take another look and let me know whether the current changes look good to you. Thanks! |
I'm ok with this but @davepagurek you may want to have a look just in case since it only changes messages in WebGL side of things. Maybe the messages can be rephrased in some cases as well but we can possibly do this in another PR. Do merge if it looks good to you @davepagurek. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
@all-contributors please add @chechenxu for code |
I've put up a pull request to add @chechenxu! 🎉 |
@davepagurek @limzykenneth Thank you! |
Resolves part of #5649
Changes:
Replace some throw error with friendly error system message.
PR Checklist
npm run lint
passes