Skip to content

Overhaul custom shapes for p5.js 2.0 #5228

Overhaul custom shapes for p5.js 2.0

Overhaul custom shapes for p5.js 2.0 #5228

Triggered via pull request December 7, 2024 16:57
Status Failure
Total duration 2m 22s
Artifacts

ci-test.yml

on: pull_request

Annotations

10 errors and 1 warning
test/unit/core/vertex.js > Vertex > p5.prototype.bezierVertex > _friendlyError is called. vertex() should be used once before bezierVertex(): src/shape/custom_shapes.js#L859
TypeError: Cannot read properties of undefined (reading 'kind') ❯ #generalVertex src/shape/custom_shapes.js:859:38 ❯ Shape.bezierVertex src/shape/custom_shapes.js:877:24 ❯ Renderer2D.bezierVertex src/core/p5.Renderer.js:128:23 ❯ fn.bezierVertex src/shape/vertex.js:706:24 ❯ test/unit/core/vertex.js:46:12
test/unit/webgl/p5.Framebuffer.js > p5.Framebuffer > get() > get() creates a p5.Image with 1x pixel density: src/webgl/ShapeBuilder.js#L455
TypeError: Cannot read properties of undefined (reading 'push') ❯ ShapeBuilder._tesselateShape src/webgl/ShapeBuilder.js:455:35 ❯ ShapeBuilder._processVertices src/webgl/ShapeBuilder.js:346:12 ❯ ShapeBuilder.endShape src/webgl/ShapeBuilder.js:151:10 ❯ RendererGL.legacyEndShape src/webgl/p5.RendererGL.js:490:23 ❯ RendererGL.image src/webgl/3d_primitives.js:3305:10 ❯ fn.image src/image/loading_displaying.js:1133:20 ❯ test/unit/webgl/p5.Framebuffer.js:469:12
test/unit/webgl/p5.Framebuffer.js > p5.Framebuffer > loadPixels works in arbitrary order for multiple framebuffers: src/webgl/ShapeBuilder.js#L455
TypeError: Cannot read properties of undefined (reading 'push') ❯ ShapeBuilder._tesselateShape src/webgl/ShapeBuilder.js:455:35 ❯ ShapeBuilder._processVertices src/webgl/ShapeBuilder.js:346:12 ❯ ShapeBuilder.endShape src/webgl/ShapeBuilder.js:151:10 ❯ RendererGL.legacyEndShape src/webgl/p5.RendererGL.js:490:23 ❯ RendererGL.image src/webgl/3d_primitives.js:3305:10 ❯ Framebuffer.updatePixels src/webgl/p5.Framebuffer.js:1565:21 ❯ test/unit/webgl/p5.Framebuffer.js:510:12
test/unit/webgl/p5.Framebuffer.js > p5.Framebuffer > nesting > with antialiasing off > one can read a nested framebuffer: src/webgl/ShapeBuilder.js#L455
TypeError: Cannot read properties of undefined (reading 'push') ❯ ShapeBuilder._tesselateShape src/webgl/ShapeBuilder.js:455:35 ❯ ShapeBuilder._processVertices src/webgl/ShapeBuilder.js:346:12 ❯ ShapeBuilder.endShape src/webgl/ShapeBuilder.js:151:10 ❯ RendererGL.legacyEndShape src/webgl/p5.RendererGL.js:490:23 ❯ RendererGL.image src/webgl/3d_primitives.js:3305:10 ❯ fn.image src/image/loading_displaying.js:1133:20 ❯ test/unit/webgl/p5.Framebuffer.js:602:16
test/unit/webgl/p5.Framebuffer.js > p5.Framebuffer > nesting > with antialiasing on > one can read a nested framebuffer: src/webgl/ShapeBuilder.js#L455
TypeError: Cannot read properties of undefined (reading 'push') ❯ ShapeBuilder._tesselateShape src/webgl/ShapeBuilder.js:455:35 ❯ ShapeBuilder._processVertices src/webgl/ShapeBuilder.js:346:12 ❯ ShapeBuilder.endShape src/webgl/ShapeBuilder.js:151:10 ❯ RendererGL.legacyEndShape src/webgl/p5.RendererGL.js:490:23 ❯ RendererGL.image src/webgl/3d_primitives.js:3305:10 ❯ fn.image src/image/loading_displaying.js:1133:20 ❯ test/unit/webgl/p5.Framebuffer.js:602:16
test/unit/webgl/p5.Geometry.js > p5.Geometry > buildGeometry > Immediate mode constructs are translated correctly: src/shape/vertex.js#L1579
TypeError: this._renderer.quadraticVertex is not a function ❯ fn.quadraticVertex src/shape/vertex.js:1579:22 ❯ test/unit/webgl/p5.Geometry.js:227:14 ❯ assertGeometryRendersMatch test/unit/webgl/p5.Geometry.js:181:9 ❯ test/unit/webgl/p5.Geometry.js:215:7
test/unit/webgl/p5.Geometry.js > p5.Geometry > buildGeometry > freeGeometry() cleans up resources: src/shape/custom_shapes.js#L92
Error: Getter vertexCapacity must be implemented. ❯ get vertexCapacity src/shape/custom_shapes.js:92:11 ❯ QuadStrip.addToShape src/shape/custom_shapes.js:122:41 ❯ #generalVertex src/shape/custom_shapes.js:868:27 ❯ Shape.vertex src/shape/custom_shapes.js:872:38 ❯ RendererGL.vertex src/core/p5.Renderer.js:183:23 ❯ fn.vertex src/shape/custom_shapes.js:1668:20 ❯ drawShape test/unit/webgl/p5.Geometry.js:280:14 ❯ RendererGL.buildGeometry src/webgl/p5.RendererGL.js:432:5 ❯ fn.buildGeometry src/webgl/3d_primitives.js:835:27 ❯ test/unit/webgl/p5.Geometry.js:286:25
test/unit/webgl/p5.RendererGL.js > p5.RendererGL > filter shader > custom shaders > work with a 2D main canvas: src/webgl/ShapeBuilder.js#L455
TypeError: Cannot read properties of undefined (reading 'push') ❯ ShapeBuilder._tesselateShape src/webgl/ShapeBuilder.js:455:35 ❯ ShapeBuilder._processVertices src/webgl/ShapeBuilder.js:346:12 ❯ ShapeBuilder.endShape src/webgl/ShapeBuilder.js:151:10 ❯ RendererGL.legacyEndShape src/webgl/p5.RendererGL.js:490:23 ❯ RendererGL.image src/webgl/3d_primitives.js:3305:10 ❯ fn._copyHelper src/image/pixels.js:412:26 ❯ fn.copy src/image/pixels.js:382:8 ❯ fn.filter src/image/pixels.js:758:27 ❯ testFilterShader test/unit/webgl/p5.RendererGL.js:239:16 ❯ test/unit/webgl/p5.RendererGL.js:249:9
test/unit/webgl/p5.RendererGL.js > p5.RendererGL > filter shader > custom shaders > work with a WebGL main canvas: src/webgl/ShapeBuilder.js#L455
TypeError: Cannot read properties of undefined (reading 'push') ❯ ShapeBuilder._tesselateShape src/webgl/ShapeBuilder.js:455:35 ❯ ShapeBuilder._processVertices src/webgl/ShapeBuilder.js:346:12 ❯ ShapeBuilder.endShape src/webgl/ShapeBuilder.js:151:10 ❯ RendererGL.legacyEndShape src/webgl/p5.RendererGL.js:490:23 ❯ RendererGL.image src/webgl/3d_primitives.js:3305:10 ❯ RendererGL.filter src/webgl/p5.RendererGL.js:1203:10 ❯ fn.filter src/image/pixels.js:730:22 ❯ testFilterShader test/unit/webgl/p5.RendererGL.js:239:16 ❯ test/unit/webgl/p5.RendererGL.js:254:9
test/unit/webgl/p5.RendererGL.js > p5.RendererGL > filter shader > custom shaders > work with a 2D graphic: src/webgl/ShapeBuilder.js#L455
TypeError: Cannot read properties of undefined (reading 'push') ❯ ShapeBuilder._tesselateShape src/webgl/ShapeBuilder.js:455:35 ❯ ShapeBuilder._processVertices src/webgl/ShapeBuilder.js:346:12 ❯ ShapeBuilder.endShape src/webgl/ShapeBuilder.js:151:10 ❯ RendererGL.legacyEndShape src/webgl/p5.RendererGL.js:490:23 ❯ RendererGL.image src/webgl/3d_primitives.js:3305:10 ❯ fn._copyHelper src/image/pixels.js:412:26 ❯ fn.copy src/image/pixels.js:382:8 ❯ fn.filter src/image/pixels.js:758:27 ❯ testFilterShader test/unit/webgl/p5.RendererGL.js:239:16 ❯ test/unit/webgl/p5.RendererGL.js:260:9
test
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636