[Fix] added support for XES composite list attributes #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrisvu
changed the title
|
Thanks. This is a contribution that from what I understood is going to be part of a larger set of PRs. We would need to finalize a "contribution level agreement" before merging (as the contribution is non-trivial) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The XES importer would throw an exception when encountering list attributes containing nested composite attributes (meta-attributes or other list attributes)
Solution: Added missing parsing cases to the
__parse_attributefunction in the XES importerAdditions:
XesCompositeAttTesttest case was added to the existing test suitesImpact: this PR lays the groundwork for extending supported event log formats within the PM4Py library