-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the payload include the raw data of the delivery body. #55
Conversation
This commit makes probot/smee-client#151 work. |
Hey there, Any chance we could make progress on merging this pull request? This is needed for #9 and, while it's not strictly necessary to be able to check the signature in development, I think it would be great if we could do it to avoid issues when pushing the app to production. Thanks! |
Also needed for #78 |
@wolfy1339 hey there! Have you deployed this change to smee.io as I don't see any Since I saw this got fixed, I wanted to implement signature checking for requests coming from smee.io but can't. Am I missing something? Thanks! |
(you probably don't remember me but we discussed a while ago when smee.io had some issues - I'm working on https://github.com/quarkiverse/quarkus-github-app/)
|
Unfortunately, I have no control over the deployed version on smee.io I'll see if I can't get in touch with the proper person to deploy a newer revision |
Thanks, that would be awesome. This has been a long standing issue on our side. Let me know how it goes :). |
@wolfy1339 any news on this front? Thanks! |
No description provided.