Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the payload include the raw data of the delivery body. #55

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

fourdollars
Copy link
Contributor

No description provided.

@fourdollars
Copy link
Contributor Author

This commit makes probot/smee-client#151 work.

@gsmet
Copy link

gsmet commented Nov 16, 2020

Hey there,

Any chance we could make progress on merging this pull request?

This is needed for #9 and, while it's not strictly necessary to be able to check the signature in development, I think it would be great if we could do it to avoid issues when pushing the app to production.

Thanks!

@CRogers
Copy link

CRogers commented Aug 18, 2021

Also needed for #78

@wolfy1339 wolfy1339 added the enhancement New feature or request label Jul 23, 2024
@wolfy1339 wolfy1339 merged commit 8c33d74 into probot:master Jul 23, 2024
4 checks passed
@gsmet
Copy link

gsmet commented Aug 23, 2024

@wolfy1339 hey there! Have you deployed this change to smee.io as I don't see any rawdata in what I receive from there.

Since I saw this got fixed, I wanted to implement signature checking for requests coming from smee.io but can't.

Am I missing something?

Thanks!

@gsmet
Copy link

gsmet commented Aug 23, 2024

(you probably don't remember me but we discussed a while ago when smee.io had some issues - I'm working on https://github.com/quarkiverse/quarkus-github-app/)

GitHub
Develop your GitHub Apps in Java with Quarkus. Contribute to quarkiverse/quarkus-github-app development by creating an account on GitHub.

@wolfy1339
Copy link
Contributor

Unfortunately, I have no control over the deployed version on smee.io

I'll see if I can't get in touch with the proper person to deploy a newer revision

@gsmet
Copy link

gsmet commented Aug 23, 2024

Thanks, that would be awesome. This has been a long standing issue on our side. Let me know how it goes :).

@gsmet
Copy link

gsmet commented Oct 3, 2024

@wolfy1339 any news on this front? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants