Support golangci-linter

[lcd1232]

• Adds support golangci-linter in CI/CD and locally (pre-commit run --all-files)
• Fixes some linter warnings (not all of them since I don't know how it should work)

[probonopd]

Thanks @lcd1232

Getting

Error: ../internal/helpers/appdir.go:157:16: undefined: errors.Join
Error: ../internal/helpers/appdir.go:177:16: undefined: errors.Join
note: module requires Go 1.20
Error: Process completed with exit code 2.

Do you know what is going on there?

[lcd1232]

@probonopd it seems like you have go version lower than go1.20. Could you check what's your version using go version?

[probonopd]

Isn't this where you set it?

go-appimage/.github/workflows/lint.yml

Line 10 in 42e24a3

go-version: '^1.20.x'

[lcd1232]

Since it's already required in go.mod

[probonopd]

Thank you very much.
Looks like it is working as intended now?

@CalebQ42 how do you like this?

[CalebQ42]

Ultimately I think having a consistent linter strategy is a good thing, but I'm not sure golangci-linter is a good choice. It doesn't seem to provides any tangible benefits vs using a single linter. I personally have been using staticcheck since it's the default for VS Code and golangci-linter didn't seem to catch anything new in this project or any of my other projects. Additionally on golangci-linter's own website it says it includes staticcheck even though it's author is against it, which turns me off enough that I personally won't be using it in my personal projects.