-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eth): introduce output type for passing full event msgs #40
Conversation
* main: build(deps): bump github.com/golang-jwt/jwt/v4 from 4.5.0 to 4.5.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mattevans for the PR. overall, LGTM, nice and clean. I just have one peaky comment that could even be ignored.
@mattevans looks super clean, thanks! Feel free to merge 👍 Just one suggestion (not blocking the merge), the type DataStream interface {
Start(ctx context.Context) error
Stop(ctx context.Context) error
PutRecord(ctx context.Context, event *TraceEvent) error
Type() DataStreamType
EventRenderer() DataStreamRenderer // or called something else
} This would avoid the indirection of the output type switch. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
========================================
+ Coverage 7.75% 9.44% +1.69%
========================================
Files 7 34 +27
Lines 400 4679 +4279
========================================
+ Hits 31 442 +411
- Misses 361 4220 +3859
- Partials 8 17 +9 ☔ View full report in Codecov by Sentry. |
Thanks 🙌 I think if I did this, it would mean the Really appreciate the such prompt reviews @dennis-tra @cortze. It looks like there's a few workflows awaiting approval before it can be merged. I don't have perms to kick them off. |
Oh, of course! Yeah, let's avoid that. Thanks for pointing this out 👍 |
👋 Hey team, it was great to meet some of you at DC7.
Xatu consumes Hermes events via the
DataStreamTypeCallback
and would really benefit in having the entire event payload passed-through. This PR introduces the concept of anDataStreamOutputType
and implementsKinesis
andFull
renderers for each.map[string]any
for its event payload data.Running Locally