-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BlockByRangeV2 request #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but it seems that BlocksByRangeV2
is never used. Is that normal?
There is no need to use it internally while the Hermes is running, but it's useful when you import Hermes as an EthNode service. I could add some testing function if you think is necessary |
If it isn't too complicated it would be good to add some tests 👍🏻 |
My bad, I've added some tests for all the ReqResp calls, but it relies on a local Prysm node.
Is it okay to Skip the test? I think that adding a docker image of Prysm to the test setup just to run these tests is overkill. |
Yes it is totally fine to skip this test. |
Description
We currently support all the libp2p protocols defined at the spec (when the requests are incoming); however, the current code doesn't allow us to request some of them actively (we miss requesting Blocks and Blobs).
This PR extends the list of Request that
Hermes
can do to support requestingBlocksByRangeV2
:The Trace would look like this:
OPTIONAL: If needed, I could also add the three missing calls (ref):
BlocksByRoot
,BlobSidecarByRange
, andBlobSidecarByRoot
), but I'll save the work bandwidth for now.