Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add achingbrain to read the probelab-infra repo cc: @SgtPooki #24

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

cortze
Copy link
Contributor

@cortze cortze commented Apr 9, 2024

Summary

Grant @achingbrain reading permissions to the probelab-infra repo.

Why do you need this?

As suggested by Russell (@SgtPooki), @achingbrain should have at least reading access to the infra repo to see how is the Helia monitoring set up.

What else do we need to know?

DRI: @cortze

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@cortze cortze requested a review from yiannisbot April 9, 2024 07:41
Copy link
Contributor

github-actions bot commented Apr 9, 2024

The following access changes will be introduced as a result of applying the plan:

Access Changes
User achingbrain:
  - will gain pull permission to probelab-infra

Copy link
Contributor

github-actions bot commented Apr 9, 2024

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

probe-lab

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # github_repository_collaborator.this["probelab-infra:achingbrain"] will be created
  + resource "github_repository_collaborator" "this" {
      + id                          = (known after apply)
      + invitation_id               = (known after apply)
      + permission                  = "pull"
      + permission_diff_suppression = false
      + repository                  = "probelab-infra"
      + username                    = "achingbrain"
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Copy link
Member

@yiannisbot yiannisbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. At a later stage we should consider removing whizzzkid, since I don't believe he needs access anymore.

@cortze cortze merged commit d5031d1 into master Apr 9, 2024
6 checks passed
@cortze cortze deleted the grant-alex-reading-infra branch April 9, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants