This repository has been archived by the owner on Jun 19, 2020. It is now read-only.
연습문제 26 입력 값 검증 #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
코딩 트레이닝 by 브라이언호건 27번문제
ohahohah
suggested changes
Jun 28, 2018
| answer = input("Enter the ZIP code:") | ||
| p = re.compile('^[0-9]*$') | ||
| m = p.match(answer) | ||
| if m: |
There was a problem hiding this comment.
유효성 검사 부분을 분리하는건 어떻게 생각하시나요? 한 메소드에 여러가지 역할들이 구현되어있는 거 같아요
There was a problem hiding this comment.
분리하겠습니다. validateInput은 구현중이였어요~
| answer = input("Enter the Employee ID:") | ||
| p = re.compile('([a-zA-Z]{1,2})\-([0-9]{4})') | ||
| m = p.match(answer) | ||
| if m: |
There was a problem hiding this comment.
유효성 검사 부분을 분리하는건 어떻게 생각하시나요? 한 메소드에 여러가지 역할들이 구현되어있는 거 같아요
| print("The "+label+" name must be filled in") | ||
| elif len(answer) == 1: | ||
| print("\""+answer+"\" is not a valid "+label+ " name. It is too short.") | ||
| else: |
There was a problem hiding this comment.
이 else는 아무 역할이 없는 거 같은데 삭제하는 게 저희 연습하는 취지에 맞는 거 같아요.
|
|
||
| def input_zip_code(self): | ||
| answer = input("Enter the ZIP code:") | ||
| p = re.compile('^[0-9]*$') |
There was a problem hiding this comment.
예에~ zipcode제한수는 없어여 :)
| else: | ||
| pass | ||
|
|
||
| def input_name(self, label): |
There was a problem hiding this comment.
input도 동사로 쓸수있던데 어떤게 더 나은 이름일까요? enter?
| a = input("Enter the "+label+" name:") | ||
| self.check_value_name(label, a) | ||
|
|
||
| def input_zip_code(self): |
| else: | ||
| print('The ZIP code must be numeric:' + answer) | ||
|
|
||
| def input_employee_id(self): |
- input에서 enter로 메소드이름 컨벤션 - else remove
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
코딩 트레이닝 by 브라이언호건 27번문제
issue #5