Skip to content

Commit

Permalink
Merge pull request #99 from privy-open-source/ci/upgrade-node-20
Browse files Browse the repository at this point in the history
ci: upgrade node `20`
  • Loading branch information
adenvt authored Oct 11, 2024
2 parents 705d028 + ef0b0c8 commit e2aba43
Show file tree
Hide file tree
Showing 6 changed files with 195 additions and 11 deletions.
13 changes: 6 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,19 @@ on:
branches: [main]
pull_request:
branches: [main]
merge_group:
types: [checks_requested]

jobs:
test:
runs-on: ${{ matrix.os }}
runs-on: ubuntu-latest

strategy:
fail-fast: false
matrix:
os:
- ubuntu-latest
node-version:
- 16
- 18
- 19
- 20
- 22

steps:
- name: Git Checkout
Expand Down Expand Up @@ -59,6 +58,6 @@ jobs:

- name: Upload to Codecov
uses: codecov/codecov-action@v3
if: matrix.node-version == 16 && matrix.os == 'ubuntu-latest'
if: matrix.node-version == 20
with:
fail_ci_if_error: false
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18
20
186 changes: 186 additions & 0 deletions assets/fixed-vs-fit.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion packages/pena-react-native/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"allowUnreachableCode": false,
"allowUnusedLabels": false,
"esModuleInterop": true,
"importsNotUsedAsValues": "error",
"forceConsistentCasingInFileNames": true,
"jsx": "react",
"lib": ["esnext"],
Expand Down
2 changes: 1 addition & 1 deletion packages/pena-vue/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ npm install --save @privyid/pena-vue @privyid/pena
yarn add @privyid/pena-vue @privyid/pena
```

### Nuxt 2
### Nuxt

You need to transpile this package, add this in your `nuxt.config.js`.

Expand Down
2 changes: 1 addition & 1 deletion packages/pena/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ on your web UI. However, `fixed` more easy to use, and better suit to any web UI

If you have only Pena as a content in your page. We **recommended** to use `fit` layout.

![fixed-vs-fixed](https://privy-open-source.github.io/design-system/assets/fixed-vs-fit.8d785873.svg)
![fixed-vs-fixed](../../assets/fixed-vs-fit.svg)

## Using CDN

Expand Down

0 comments on commit e2aba43

Please sign in to comment.