Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort on panics #1494

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Abort on panics #1494

merged 1 commit into from
Dec 12, 2024

Conversation

akoshelev
Copy link
Collaborator

See the comment for reasoning

See the comment for reasoning
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.29%. Comparing base (4f112ad) to head (db2b416).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1494   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files         237      237           
  Lines       43510    43510           
=======================================
+ Hits        40592    40594    +2     
+ Misses       2918     2916    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyleiserson
Copy link
Collaborator

Is there a reason not to set this in debug builds as well?

@akoshelev
Copy link
Collaborator Author

akoshelev commented Dec 12, 2024

Is there a reason not to set this in debug builds as well?

no particular reason except maybe getting better observability if we can something really stupid (with unsafe) that can only be seen on function stack cleanup?

@akoshelev akoshelev merged commit 0703ad5 into private-attribution:main Dec 12, 2024
13 checks passed
@akoshelev
Copy link
Collaborator Author

I can add abort on panics for debug builds as separate PR if that's what we want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants