Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to put helper logs into a file #1493

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

akoshelev
Copy link
Collaborator

We need it because stderr is often dropped by the external services (like Kubernetes)

This also adds some verification for our e2e tests to make sure we write something into them

We need it because stderr is often dropped by the external services
(like Kubernetes)
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 14 lines in your changes missing coverage. Please review.

Project coverage is 93.24%. Comparing base (4f112ad) to head (60d158d).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
ipa-core/src/cli/verbosity.rs 33.33% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1493      +/-   ##
==========================================
- Coverage   93.29%   93.24%   -0.05%     
==========================================
  Files         237      237              
  Lines       43510    43534      +24     
==========================================
+ Hits        40592    40595       +3     
- Misses       2918     2939      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -20,6 +24,11 @@ pub struct Verbosity {
/// Verbose mode (-v, or -vv for even more verbose)
#[arg(short, long, action = clap::ArgAction::Count, global = true)]
verbose: u8,

/// This option is mutually exclusive with console logging. If set,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have both? K8s logs are easy to pull for many shards whereas going into each host is a hassle

@akoshelev akoshelev merged commit e51f33e into private-attribution:main Dec 12, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants