fix bug where an edge case exception causes a query to not be removed…

… from active running queries
private-attribution · Sep 26, 2024 · 679dada · 679dada
1 parent 40e7c9b
commit 679dada
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/sidecar/app/query/base.py b/sidecar/app/query/base.py
@@ -201,8 +201,11 @@ def run_query(self, query: Query):
             )
 
         self.running_queries[query.query_id] = query
-        query.start()
-        del self.running_queries[query.query_id]
+        try:
+            query.start()
+        finally:
+            # always remove this
+            del self.running_queries[query.query_id]
 
     @property
     def capacity_available(self):